Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed hardcoded date in SetCookieTests.test_far_expiration(). #16459

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Removed hardcoded date in SetCookieTests.test_far_expiration(). #16459

merged 1 commit into from
Feb 7, 2023

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Jan 16, 2023 •
edited
Loading

This is a continuation of a92c838

To avoid triggering python/cpython#101069
we do not yet set expiration after 2038, but just one year ahead.

@felixxm felixxm changed the title Update test to not fail in 2038 Removed hardcoded date in SetCookieTests.test_far_expiration(). Feb 7, 2023
@felixxm
Copy link
Member

felixxm commented Feb 7, 2023

@bmwiedemann Thanks 👍

@felixxm felixxm merged commit b4cdcbf into django:main Feb 7, 2023
@felixxm felixxm temporarily deployed to schedules February 8, 2023 02:55 — with GitHub Actions Inactive
@bmwiedemann bmwiedemann deleted the ftbfs2038 branch February 8, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmwiedemann @felixxm