Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin /ws version in discord.js #10427

Merged
merged 2 commits into from
Aug 8, 2024
Merged

chore: pin /ws version in discord.js #10427

merged 2 commits into from
Aug 8, 2024

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Aug 4, 2024

Please describe the changes this PR makes and why it should be merged:
There have been breaking changes in /ws which discord.js doesn't support, so pinning the version to not break potential future v14 releases

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@almeidx almeidx requested review from a team and iCrawl as code owners August 4, 2024 01:41
Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 9:51pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 9:51pm

packages/discord.js/package.json Show resolved Hide resolved
Copy link
Member

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what vlad said

@almeidx almeidx added this to the discord.js 14.16 milestone Aug 6, 2024
@kodiakhq kodiakhq bot merged commit 432e9b8 into main Aug 8, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the chore/pin-ws branch August 8, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants