Fix display of M2A field values in render-template
#23002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3098d8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paescuj
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Can we enrich the item data via the related-values display with the collection prop, and then ensure in render-template that the data is only used if it matches the collection specified in the key?
That info seems to be missing at the moment (in contrast to your example), and without such a filtering, a key would match all linked collections (i.e. the collection part in item:<collection> has no effect).
|
Closing this to be revisited later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
When trying to display M2A related fields in the
related-valuesdisplay, therender-templatecomponent is used which does not account for the field keys containing aitem:<collection>part. Therender-templatereceives, for example a value of{ "collection":"page_link", "id":1, "item": { "name":"Page Link", "page_id": { "title":"New Page" } } }and then, when trying to render the template
{{collection}}: {{item:page_link.name}}{{item:external_link.name}}({{item:page_link.page_id.title}})it tried to access the value with the keyitem:page_link.namewhich does not exist.What's changed:
:if it is in the first field name of the field key. This allows for at least top level M2A fields to be rendered in the template. This currently does not extend support to work for M2A fields nested under a M2O.Potential Risks / Drawbacks
Review Notes / Questions
Fixes #10601