Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.16] Fix NLL compatibility #649

Merged
merged 1 commit into from
Sep 8, 2019
Merged

[v0.16] Fix NLL compatibility #649

merged 1 commit into from
Sep 8, 2019

Conversation

Mark-Simulacrum
Copy link

Uncovered by a crater run in rust-lang/rust#63565, the most recent v0.16.x version breaks when NLL is fully enabled. This PR is targeted to be based atop tag v0.16.13 (it's probably easiest to merge it manually, unless you want to create a branch for this PR to target).

@est31
Copy link
Contributor

est31 commented Sep 8, 2019

See also #561 , #562 and #616 . Interesting that 0.16.x is still used so much in the wild.

@sebcrozet sebcrozet changed the base branch from dev to v0.16 September 8, 2019 18:44
@sebcrozet
Copy link
Member

sebcrozet commented Sep 8, 2019

@Mark-Simulacrum Thank you for this PR! I've created a v0.16 branch which is the new target of this PR. Why is the #![allow(deprecated)] necessary?

@Mark-Simulacrum
Copy link
Author

Ah, I think I forgot to drop that, it's not strictly necessary, I can drop it if you'd like.

@sebcrozet
Copy link
Member

I can drop it if you'd like.

That would be great!

@Mark-Simulacrum
Copy link
Author

Okay, I've dropped the deprecation commit, so this should be good to go. (Closed and reopened because CI failed due to seemingly unrelated -- perhaps network -- reasons).

@sebcrozet
Copy link
Member

Thanks! Don't mind the CI. It will fail because of a changes on travis ubuntu version. We fixed our .travis.yml after the 16.x releases.

@sebcrozet sebcrozet merged commit b015544 into dimforge:v0.16 Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants