Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid eager creation of tasks for Spotless plugin #617

Merged
merged 3 commits into from
Jun 18, 2020
Merged

Avoid eager creation of tasks for Spotless plugin #617

merged 3 commits into from
Jun 18, 2020

Commits on Jun 18, 2020

  1. Do not eagerly create format-specific spotless tasks 

    Previously applying the Spotless plugin resulted in a many tasks to be created
per subproject, even for an invocation like `gradle help`.
Using "Task configuration avoidance" APIs means that these tasks will
not be constructed if they will not be required in the task graph.
    @bigdaz
    bigdaz committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    ef2aae4 View commit details
    Browse the repository at this point in the history

  2. Do not eagerly create per-project spotless tasks 

    With this commit, running `./gradlew help -PspotlessModern=true` will no longer
the `spotless`, `spotlessCheck` or `spotlessApply` tasks if they are not
required for task execution. The only remaining task that is eagerly constructed
is "spotlessInternalRegisterDependencies".
    @bigdaz
    bigdaz committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    621af48 View commit details
    Browse the repository at this point in the history

  3. Update TODO items in code

    @bigdaz
    bigdaz committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    78cfd65 View commit details
    Browse the repository at this point in the history