-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Gradle Java Toolchains #2211
Comments
This comment was marked as resolved.
This comment was marked as resolved.
Hi @Goooler, this issue is relevant for my project as well and I feel that I could contribute to fix the issue. But before I start working on PR, I wanted to make sure that implementation idea is viable... The idea is to:
@Goooler, please let me know what you think about it and if you have any suggestions. |
Looks like this might be a duplicate of #724 |
@mr-serjey Thanks for your response! I would prefer the second. WDYT? @nedtwigg |
Correct, this is a dupe of #724, even though this issue has the better discussion, I'm going to close this one so that watchers of the original issue will get notified if something gets merged. I don't have a preference for 1 vs 2, so I defer to the implementor and I think @Goooler has good insight that option |
Gradle version: 7.6.4
Spotless version: 6.21.0
Java version: Coretto 17.0.11
Operating system and version: Mac OS 14.5
The Spotless Gradle Plugin does not support Gradle Java Toolchains
If Gradle is run on a Java 17 JDK. But we compile/test Java 21 code using the following toolchain configuration
Gradle can compile the Java 21 code but the Spotless Gradle Plugin does not use the toolchain JDK and fails with an exception when executing
I have created a basic project with steps to recreate the problem.
Do you have any plans to support Java Toolchains?
The text was updated successfully, but these errors were encountered: