Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes InsertOrIgnore/Replace items in combination_clause public for 3rd party backends #4236

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Makes InsertOrIgnore/Replace items in combination_clause public for 3rd party backends #4236

merged 3 commits into from
Oct 10, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Sep 4, 2024 •
edited
Loading

make items in combination_clause public for third-party backends

  • SupportsCombinationClause
  • All, Distinct, Except, intersect, ParenthesisWrapper, Union
  • ReplaceOrIgnore

These are the last third-party public exports needed to make diesel-wasm-sqlite more feature-complete with the diesel sqlite backend

@insipx insipx force-pushed the insipx/sqlite-replace-ignore-pub branch from a319c6a to 78ece4f Compare September 5, 2024 16:34
@weiznich weiznich requested a review from a team September 6, 2024 06:06
weiznich
weiznich requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks fine, but you likely need to rerun the compile_fail tests to update the error messages there. For that please execute TRYBUILD=overwrite cargo test in diesel_compile_tests and push the changes.

@insipx
make InsertOrIgnore Replace public for 3rd party backend
0b3b200
@insipx
make items in combination_clause public for third-party backends
019e44f 
- `SupportsCombinationClause`
- All, Distinct, Except, intersect, ParenthesisWrapper, Union
@insipx insipx force-pushed the insipx/sqlite-replace-ignore-pub branch 2 times, most recently from 6e0a813 to 019e44f Compare October 7, 2024 16:56
@insipx insipx force-pushed the insipx/sqlite-replace-ignore-pub branch from aaecfac to a186318 Compare October 7, 2024 17:10
@insipx insipx requested a review from weiznich October 7, 2024 18:13
@insipx
Copy link
Contributor Author

insipx commented Oct 7, 2024 •
edited
Loading

Hey @weiznich , got these compile tests in. Sorry it took a while! Got sidetracked with some other work

weiznich
weiznich approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks now good for me. Thanks for the update 👍

@weiznich weiznich added this pull request to the merge queue Oct 10, 2024
Merged via the queue into diesel-rs:master with commit 9ed7de2 Oct 10, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiznich weiznich weiznich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@insipx @weiznich