Implement pgrange union #4135
Merged
Implement pgrange union #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijairamg
force-pushed
the
pgrange-range-ops
branch
13 times, most recently
from
1c801d3
to
9bab83e
Compare
weiznich
reviewed
Jul 29, 2024
| R: crate::expression::Expression<SqlType = Range<ST>>, | ||
| ST: SqlType TypedExpressionType, | ||
| { | ||
| type SqlType = ST; |
There was a problem hiding this comment.
That's the problematic line that's causing the error.
You specify here that range_a.union_range(range_b) return the inner type of the range instead. You want type SqlType = Range<ST> instead, which just says that the operator returns a range as well.
That written: You should likely use the infix_operator!() macro instead to generate all this code for you. It should be much easier that way.
There was a problem hiding this comment.
Thanks for the pointer.
My bad! Should have noticed the __diesel_infix_operator!.
vijairamg
force-pushed
the
pgrange-range-ops
branch
10 times, most recently
from
955c02e
to
6b6261f
Compare
vijairamg
force-pushed
the
pgrange-range-ops
branch
from
758f121
to
21b0cb1
Compare
added 2 commits
July 30, 2024 19:00
vijairamg
force-pushed
the
pgrange-range-ops
branch
from
21b0cb1
to
210a290
Compare
vijairamg
force-pushed
the
pgrange-range-ops
branch
from
5359e39
to
f2588e5
Compare
vijairamg
force-pushed
the
pgrange-range-ops
branch
from
f2588e5
to
9d1b6e4
Compare
|
Let me know if any of the names need to be changed. |
weiznich
approved these changes
Aug 1, 2024
weiznich
force-pushed
the
pgrange-range-ops
branch
from
e11b6ec
to
c192778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
anyrange anyrange -> anyrange,anyrange * anyrange -> anyrangeandanyrange - anyrange -> anyrangepart of #4092