Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_file_status->check_input_files #941

Merged
merged 6 commits into from
Apr 15, 2015
Merged

check_file_status->check_input_files #941

merged 6 commits into from
Apr 15, 2015

Conversation

proteasome
Copy link
Contributor

No description provided.

@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@proteasome
Copy link
Contributor Author

please retest

@mr-c
Copy link
Contributor

mr-c commented Apr 14, 2015

Jenkins, ok to test

@proteasome
Copy link
Contributor Author

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@proteasome
Copy link
Contributor Author

ready for review!

@proteasome proteasome mentioned this pull request Apr 14, 2015
Closed
@proteasome
Copy link
Contributor Author

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@proteasome
Copy link
Contributor Author

ready for review!

@mr-c
Copy link
Contributor

mr-c commented Apr 15, 2015

Looks good! I'm not seeing a ChangeLog entry, though.

@proteasome
Copy link
Contributor Author

ChangeLog entry made
review for review!

@proteasome
Copy link
Contributor Author

@mr-c ready to review!

mr-c
mr-c reviewed Apr 15, 2015
View reviewed changes
ChangeLog
@@ -1,3 1,15 @@
2015-04-15 en zyme <[email protected]>
* khmer/khmer/kfile.py: check_file_status() -> check_input_files()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I need a blank line above this one.

@proteasome
Copy link
Contributor Author

@mr-c ready for review!

mr-c added a commit that referenced this pull request Apr 15, 2015
@mr-c
Merge pull request #941 from proteasome/fix/927
60008c0 
check_file_status->check_input_files
@mr-c mr-c merged commit 60008c0 into dib-lab:master Apr 15, 2015
@mr-c
Copy link
Contributor

mr-c commented Apr 15, 2015

@proteasome Congratulations on your first commit to the khmer project! Your name will be included in the release notes for the next version and you'll be listed amongst our other contributors in the next software release paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@proteasome @ged-jenkins @mr-c