added check_file_status() for input_table #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@mr-c: |
| @@ -3,6 3,10 @@ | |||
| * scripts/abundance-dist.py: disambiguate documentation for force and | |||
| squash options | |||
|
|
|||
| 2015-04-13 Scott Fay <[email protected]> | |||
There was a problem hiding this comment.
At the top of the file, please :-)
Two spaces between your name and the date; two spaces between your name and your bracketed email address. Thanks!
|
Otherwise, this looks good to me! |
|
@mr-c: okay, changed to the true change history, sorry about that! |
|
Jenkins, ok to test |
mr-c
added a commit
that referenced
this pull request
Apr 13, 2015
added check_file_status() for input_table
|
@safay Congratulations on your first commit to the khmer project! Your name will be included in the release notes for the next version and you'll be listed amongst our other contributors in the next software release paper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added file status checking
check_file_status()for args.input_table in filter_abund.pyNot a documented issue, but found it while examining code for another issue.
Check for code coverage.
make pep8,make diff_pylint_report,make cppcheck, andmake docoutput. Usemake formatand manualfixing as needed.
without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?