-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output CSV format in abundance-dist.py #831
Conversation
|
ready for review |
@@ -1,3 1,7 @@ | |||
2015-02-23 Tamer A. Mansour ([email protected]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two spaces between the date and your name and two space between your name and your email address. Also use <
>
angle brackets instead of parenthesis. This is an old UNIX tradition :-)
Here's the latest checklist:
|
FYI: latest checklist is here http://khmer.readthedocs.org/en/latest/dev/coding-guidelines-and-review.html#checklist |
ready for review |
@@ -18,6 18,13 @@ | |||
|
|||
2015-02-23 Tamer A. Mansour <[email protected]> | |||
|
|||
* abundance-dist.py: Use CSV format for the histogram. Includes column |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts/abundance-dist.py
LGTM, after comments addressed. Could you also take a look at scripts/abundance-dist-single.py? :) |
@ctb it is ready |
* tests/test_scripts.py: add coverage for the new --csv option in | ||
abundance-dist.py | ||
|
||
2015-02-23 Tamer A. Mansour <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be at the top of the Changelog
Plz review before I need to update the Changelog againnnn |
LGTM. |
Add --csv argument to output CSV format with column headers