Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output CSV format in abundance-dist.py #831

Merged
merged 19 commits into from
Feb 24, 2015
Merged

Output CSV format in abundance-dist.py #831

merged 19 commits into from
Feb 24, 2015

Conversation

drtamermansour
Copy link
Member

Add --csv argument to output CSV format with column headers

@drtamermansour
Copy link
Member Author

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@drtamermansour
Copy link
Member Author

ready for review

mr-c
mr-c reviewed Feb 23, 2015
View reviewed changes
ChangeLog
@@ -1,3 1,7 @@
2015-02-23 Tamer A. Mansour ([email protected])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two spaces between the date and your name and two space between your name and your email address. Also use < > angle brackets instead of parenthesis. This is an old UNIX tradition :-)

@mr-c
Copy link
Contributor

mr-c commented Feb 23, 2015

Here's the latest checklist:

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@mr-c
Copy link
Contributor

mr-c commented Feb 23, 2015

FYI: latest checklist is here http://khmer.readthedocs.org/en/latest/dev/coding-guidelines-and-review.html#checklist

@drtamermansour drtamermansour changed the title Output CSV format in abundance.py Output CSV format in abundance-dist.py Feb 23, 2015
@mr-c mr-c mentioned this pull request Feb 23, 2015
Closed
@drtamermansour
Copy link
Member Author

ready for review

ctb
ctb reviewed Feb 23, 2015
View reviewed changes
ChangeLog
@@ -18,6 18,13 @@

2015-02-23 Tamer A. Mansour <[email protected]>

* abundance-dist.py: Use CSV format for the histogram. Includes column
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/abundance-dist.py

@ctb
Copy link
Member

ctb commented Feb 23, 2015

LGTM, after comments addressed. Could you also take a look at scripts/abundance-dist-single.py? :)

@drtamermansour
Copy link
Member Author

@ctb it is ready

mr-c
mr-c reviewed Feb 24, 2015
View reviewed changes
ChangeLog
* tests/test_scripts.py: add coverage for the new --csv option in
abundance-dist.py

2015-02-23 Tamer A. Mansour <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be at the top of the Changelog

@drtamermansour
Copy link
Member Author

Plz review before I need to update the Changelog againnnn

@ctb ctb mentioned this pull request Feb 24, 2015
Closed
@ctb
Copy link
Member

ctb commented Feb 24, 2015

LGTM.

@ctb ctb merged commit be7f683 into dib-lab:master Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drtamermansour @mr-c @ctb