Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastq-to-fasta.py #814

Merged
merged 1 commit into from
Jul 29, 2015
Merged

Update fastq-to-fasta.py #814

merged 1 commit into from
Jul 29, 2015

Conversation

ACharbonneau
Copy link
Contributor

Changed '-n' default description to match behaviour

Changed '-n' default description to match behaviour
@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@mr-c
Copy link
Contributor

mr-c commented Feb 20, 2015

Jenkins, add to testlist

@mr-c
Copy link
Contributor

mr-c commented Feb 20, 2015

@ctb
Copy link
Member

ctb commented Feb 28, 2015

ping @ACharbonneau

@ACharbonneau
Copy link
Contributor Author

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@bocajnotnef
Copy link
Contributor

ping @ACharbonneau

@ACharbonneau
Copy link
Contributor Author

Hey,

So this was only a change to the comments & help, so the description matches what the script actually does; which presumably means it will pass all the tests. However, I cannot get tests to run correctly on my machine. See: #1156 (comment)

If you guys don't want to merge it in without tests, I can close the pull request and let someone else fix it, or I'll finish the tests as soon as we get my computer to run them. Sorry :(

@mr-c
Copy link
Contributor

mr-c commented Jul 29, 2015

Let's keep this open; @bocajnotnef will polish it for you. Thank you for
your contribution!

On Wed, Jul 29, 2015, 08:28 Amanda Charbonneau [email protected]
wrote:

Hey,

So this was only a change to the comments & help, so the description
matches what the script actually does; which presumably means it will pass
all the tests. However, I cannot get tests to run correctly on my machine.
See: #1156 (comment)
#1156 (comment)

If you guys don't want to merge it in without tests, I can close the pull
request and let someone else fix it, or I'll finish the tests as soon as we
get my computer to run them. Sorry :(


Reply to this email directly or view it on GitHub
#814 (comment).

Michael R. Crusoe: Programmer & Bioinformatician [email protected]
The lab for Data Intensive Biology; University of California, Davis
https://impactstory.org/MichaelRCrusoe http://twitter.com/biocrusoe

@mr-c mr-c merged commit 954f8c2 into dib-lab:master Jul 29, 2015
@bocajnotnef
Copy link
Contributor

"Merged" #814--Thanks @ACharbonneau!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants