-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
./lib Makefile rewrite, create libkhmer.{a,so} and install target #788
Conversation
|
Whelp, merge conflict already 😵. Will rebase and push. |
Hmm, are those failures my stuff up or Jenkins'? EDIT: they're mine. Working on it now. |
Yeah, this Makefile hasn't been used in about two years. The following defines are no longer present in the codebase and can be removed: TRACE_STATE_CHANGES |
retest this please |
@mr-c Does that mean that lib/trace_logger is also obsolete? |
@kdmurray91 Not quite yet :-) |
retest this please |
Can I delete the following files:
Additionally, |
- replace most .o targets with wildcard targets - add libkhmer.so and libkhmer.a targets - Minor tidying
- Allows the version to be obtained without khmer being installed.
They were being called libkhmer.a.a and .so.so due to a copy-paste error
And add more comments
Jenkins, don't make us call Camille, retest this please!! |
Ah, I think jenkins is having trouble pulling down changes, as github's under a DDOS attack |
retest this please |
Well, closer. git fetch only failed on the OS X node that time. retest this please |
Ah, that's an actual failure. Hacky configure is hacky. |
test -f install_target/include/khmer.hh | ||
test -d install_target/lib | ||
test -f install_target/lib/libkhmer.a | ||
rm -rf install_target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should your tst.cc
be included here to catch issues similar to the Seqan header problem in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1, done
This generally looks good to me. Slap a completed checklist on this and I'll merge. |
|
retest this please |
All good to go I think @mr-c |
./lib Makefile rewrite, create libkhmer.{a,so} and install target
Thanks! |
Hi all,
This rehashes the makefile in
./lib
, adding a few targets and cleaning up. (mentioned in #776, also ping #751)Added:
libkhmer.so
shared object (how does this work on OSX? will it break due to shared objects being named X.dylib?)libkhmer.a
static archiveremoved:
*.o
targets where possiblechanges:
python setup.py something
, the old script spat out a sentence explaining this. Now, you don't need setup.py.All of this stuff probably needs testing, this started as a hack to test a few things. There's probably also some more culling that could happen in the makefile.
Cheers,
K