Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused callback code #698

Merged
merged 1 commit into from
Feb 23, 2015
Merged

remove unused callback code #698

merged 1 commit into from
Feb 23, 2015

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Dec 16, 2014

Looks like it isn't used (note all the #if(0)) and it doesn't work with multiple threads.

Let's discuss.

@mr-c mr-c force-pushed the fix/delete-callback branch 3 times, most recently from af2e266 to c0fb04e Compare February 19, 2015 22:38
@mr-c
Copy link
Contributor Author

mr-c commented Feb 19, 2015

ping @ctb @camillescott @luizirber

@mr-c
Copy link
Contributor Author

mr-c commented Feb 23, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@mr-c mr-c force-pushed the fix/delete-callback branch 2 times, most recently from e349e5c to cc176dd Compare February 23, 2015 22:48
@ctb
Copy link
Member

ctb commented Feb 23, 2015

LGTM; nice cleanup!

ctb added a commit that referenced this pull request Feb 23, 2015
@ctb
Merge pull request #698 from ged-lab/fix/delete-callback
28523f3 
remove unused callback code
@ctb ctb merged commit 28523f3 into master Feb 23, 2015
@ctb ctb deleted the fix/delete-callback branch February 23, 2015 22:54
@mr-c
Copy link
Contributor Author

mr-c commented Feb 23, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C discussion-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-c @ctb