updated diginorm for new FP rate info; corrected spelling error #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to look at code coverage; if there is no current coverage for FP rate checking, we should create an issue to add it. But, either way, not needed to merge this, IMO. |
|
Test PASSed. |
|
Ready for review. |
|
Issue #402 has been created to track the testing gap. |
|
retest this please |
This was referenced Apr 25, 2014
Closed
|
OK, ready for merge, I think. @mr-c |
mr-c
added a commit
that referenced
this pull request
May 7, 2014
updated diginorm for new FP rate info; corrected spelling error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for code coverage.
pep8/pylint,cppcheck, andmake docoutput. Useautopep8andastyle -A10if needed.