Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib 1.2.3 -> zlib 1.2.8 #336

Merged
merged 1 commit into from
Mar 25, 2014
Merged

zlib 1.2.3 -> zlib 1.2.8 #336

merged 1 commit into from
Mar 25, 2014

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Mar 19, 2014 

* Update bundled zlib version to 1.2.8 from 1.2.3. Changes of note:
"Wholesale replacement of gz* functions with faster versions"
"Added LFS (Large File Summit) support for 64-bit file offsets"
"Fix serious but very rare decompression bug"

Closes #335

Ready for reviewing

@ged-jenkins
Copy link

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/298/

@ged-jenkins
Copy link

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/299/

@mr-c
Copy link
Contributor Author

mr-c commented Mar 19, 2014

  • Is it mergable
  • Did it pass the tests?
  • N/A If it introduce new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 if needed.
  • Is it documented in the Changelog?

@mr-c mr-c added this to the 1.0 release milestone Mar 20, 2014
@ged-jenkins
Copy link

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/322/

mr-c added a commit that referenced this pull request Mar 25, 2014
@mr-c
Merge pull request #336 from ged-lab/fix/zlib-1.2.8
5036a7a 
zlib 1.2.3 -> zlib 1.2.8
@mr-c mr-c merged commit 5036a7a into master Mar 25, 2014
@mr-c mr-c deleted the fix/zlib-1.2.8 branch March 25, 2014 17:23
mr-c added a commit that referenced this pull request Apr 1, 2014
@mr-c
Merge pull request #336 from ged-lab/fix/zlib-1.2.8
5c7ef94 
zlib 1.2.3 -> zlib 1.2.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 release
Development

Successfully merging this pull request may close these issues.

zlib & bzip2 source needs to be checked for updates
2 participants
@mr-c @ged-jenkins