-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove khmer::read_parsers::IParser::ParserState::thread_id #323
Conversation
As it is unused and uninitialized. CID 1054789
Test PASSed. |
|
@luizirber, @camillescott, @ctb please review and merge :-) |
remove khmer::read_parsers::IParser::ParserState::thread_id
Who did the review on this? |
You did, outside of the elevator. On Sun, Mar 16, 2014 at 4:31 PM, C. Titus Brown [email protected]:
|
Ahh, I feared that was the case. Could we have someone else look at the code changes, please? |
@@ -424,8 424,6 @@ protected: | |||
// TODO: Set buffer size from Config. | |||
static uint64_t const BUFFER_SIZE = 127; | |||
|
|||
uint32_t thread_id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A guide to the reviewer: the only reference to khmer::read_parsers::IParser::ParserState::thread_id was in the (uint32_t const thread_id, uint8_t const trace_level) ParserState constructor where the supplied thread_id is recorded in the TraceLogger in lib/read_parsers.cc:1446 https://github.com/ged-lab/khmer/blob/358675f38c84289c8f7bd579b1558237a42c092f/lib/read_parsers.cc#L1446
remove khmer::read_parsers::IParser::ParserState::thread_id
As it is unused and uninitialized. Fixes CID 1054789