Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luiz's fix for the build failure #1207

Merged
merged 3 commits into from
Jul 29, 2015
Merged

luiz's fix for the build failure #1207

merged 3 commits into from
Jul 29, 2015

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Jul 29, 2015

Thank you @luizirber for this

@mr-c
Copy link
Contributor Author

mr-c commented Jul 29, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@mr-c
Copy link
Contributor Author

mr-c commented Jul 29, 2015

@bocajnotnef ready for review & merge

bocajnotnef added a commit that referenced this pull request Jul 29, 2015
luiz's fix for the build failure
@bocajnotnef bocajnotnef merged commit c13b4be into master Jul 29, 2015
@bocajnotnef
Copy link
Contributor

Merged #1207

@mr-c mr-c deleted the fix/build branch August 5, 2015 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants