Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed incorrect warning for max_tablesize when -M is used #1133

Merged
merged 3 commits into from
Jul 1, 2015
Merged

removed incorrect warning for max_tablesize when -M is used #1133

merged 3 commits into from
Jul 1, 2015

Conversation

ctb
Copy link
Member

@ctb ctb commented Jun 30, 2015

A leftover bug from #1050.

@ctb
Copy link
Member Author

ctb commented Jun 30, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

ready for review & merge @luizirber @camillescott @mr-c @bocajnotnef

@mr-c
Copy link
Contributor

mr-c commented Jun 30, 2015

LGTM

@ctb
Copy link
Member Author

ctb commented Jul 1, 2015

tnx

ctb added a commit that referenced this pull request Jul 1, 2015
@ctb
Merge pull request #1133 from dib-lab/fix/tablesize_warning
3689bf5 
removed incorrect warning for max_tablesize when -M is used
@ctb ctb merged commit 3689bf5 into master Jul 1, 2015
@ctb ctb deleted the fix/tablesize_warning branch July 1, 2015 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctb @mr-c