Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename counting_hash and hashbits at Python layer #872

Closed
ctb opened this issue Mar 14, 2015 · 6 comments
Closed

Rename counting_hash and hashbits at Python layer #872

ctb opened this issue Mar 14, 2015 · 6 comments
Assignees
@mr-c
Milestone
2.0

Comments

@ctb
Copy link
Member

ctb commented Mar 14, 2015

I suggest counting_table and/or bytegraph instead of counting_hash, and bitgraph instead of hashbits. (@mr-c has already renamed stopped using 'hash' in our scripts and docs).

counting_table could default to bigcounts=yes, bytegraph could default to bigcounts=no, but otherwise be the same structure.

Reason: I found it silly to be using counting_hash in my VanBUG talk when I was talking about graphs.
@mr-c
Copy link
Contributor

mr-c commented Mar 15, 2015

How about countgraph & graph?

@ctb
Copy link
Member Author

ctb commented Mar 15, 2015

On Sat, Mar 14, 2015 at 07:38:02PM -0700, Michael R. Crusoe wrote:

How about countgraph & graph?

Imprecise - wouldn't "graph" be a superset of "countgraph"? What about
"nodegraph"?

We haven't really been using the 1-bit graph implementation lately, but we may
well in the future, as well as expanding to additional kinds of graphs - exact
graphs of various flavors, and different sized bins. So maybe we can think
about that, too.

@mr-c
Copy link
Contributor

mr-c commented Mar 15, 2015

1 for nodegraph countgraph

@ctb
Copy link
Member Author

ctb commented Mar 15, 2015

On Sat, Mar 14, 2015 at 07:43:39PM -0700, Michael R. Crusoe wrote:

1 for nodegraph countgraph

Excellent.

@camillescott
Copy link
Member

1 node/countgraph as well

@anotherthomas
Copy link
Contributor

I am working on this issue.
It's been postponed until after the python3 port to avoid merge conflicts.

This was referenced May 27, 2015
Open
Merged
@ctb ctb added this to the 2.0 milestone Jun 8, 2015
@ctb ctb mentioned this issue Jun 13, 2015
Closed
15 tasks
@mr-c mr-c self-assigned this Jul 29, 2015
@mr-c mr-c mentioned this issue Jul 29, 2015
Merged
@mr-c mr-c closed this as completed in #1209 Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mr-c mr-c

Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@ctb @mr-c @anotherthomas @camillescott