Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_khmermodule.cc cleanup #728

Closed
14 of 15 tasks
mr-c opened this issue Jan 16, 2015 · 2 comments
Closed
14 of 15 tasks

_khmermodule.cc cleanup #728

mr-c opened this issue Jan 16, 2015 · 2 comments

Comments

@mr-c
Copy link
Contributor

mr-c commented Jan 16, 2015

  • tp_name field of PyTypeObjects needs to include module name; dot separated; Example: khmer.Read
  • rename all Python facing mentions of 'hash' to 'table' (and update Python code)
  • remove _common_init_Type and refactor accordingly
  • PyTypeObjects should be name khmer_${TYPENAME}_Type;
  • all PyTypeObjects should be implemented as new style Python classes
  • Type methods should use their type Object in the method signature instead of PyObject. Cast the methods to PyCFunctions in the PyMethodDef.
  • Type deallocators should use their type Object in the method signature instead of PyObject. Cast the method in tp_dealloc to (destructor)

Types to review

  • Read_Type
  • ReadParser_Type
  • ReadPairIterator_Type
  • khmer_KSubsetPartitionType
  • khmer_KCountingHashType
  • khmer_KHashbitsType
  • khmer_KLabelHashType
  • khmer_ReadAlignerType
@luizirber
Copy link
Member

Working on it: #785

@ctb
Copy link
Member

ctb commented Jun 13, 2015

More or less done (#785, #1044) and the naming scheme stuff is punted to #872.

@ctb ctb closed this as completed Jun 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants