Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root directory required to be named "wings" #575

Open
MIvanchev opened this issue Feb 9, 2024 · 2 comments
Open

Root directory required to be named "wings" #575

MIvanchev opened this issue Feb 9, 2024 · 2 comments

Comments

@MIvanchev
Copy link

Hey, I was building the package for Void Linux and noticed currently Wings expects the code to be located in a directory called wings. This is visible for instance here https://github.com/dgud/wings/blob/master/src/wings_outliner.erl#L26. This is an unusual requirement and IMHO it makes sense to change the code to be independent of the extraction dir's name.

@elblake
Copy link
Contributor

elblake commented Feb 16, 2024

While I`m not completely knowledgeable of all the specifics arrived to in the way the directories have been organized as I am mostly a plugin maker, I could be mistaken but I think the -include_lib() convention is used for e3d and intl_tools so they can be used for plugin development. The other include files more likely are intended for wings alone so they use -include() instead.

Personally when I develop plugins for wings I have ERL_COMPILER_OPTIONS set to include the wings parent directory so I can build plugins outside the wings directory.

@dgud
Copy link
Owner

dgud commented Feb 16, 2024

This is the same #429 I guess.
Erlang expects applications to be in "AppName[-Version]/substructure".
Handling include paths with a version to the application is trouble some which is why include_lib is used which handles that
automaticly. Now wings is a bit special since it since a standalone application instead of an ordinary erlang library.

99% percent builds wings from a git repo with the default name and works.
If you want some other way supply a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants