Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't flip 2D textures on load, required for texelFetch #232

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

don't flip 2D textures on load, required for texelFetch #232

wants to merge 8 commits into from

Conversation

agreppin
Copy link
Contributor

@agreppin agreppin commented Jul 8, 2021

  • display them as FlippedTexture in UI / objects preview
  • check shader program link status

@agreppin
Copy link
Contributor Author

Here is a minimal example using texelFetch.
texelFetch uses texture space coordinates to access pixels [0, size-1].

As of SHADERed 1.5.4, the logic of the texture VFlip feature is not clear. When using texelFetch in a shader, I must enable the VFlip checkbox, but the texture preview is now inverted ... which is confusing.

Attachment: quad0.zip
PS: please read this dicussion: How do you deal with images being inverted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@agreppin