Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the option to initialize a store with an extra argument that will be passed to each invocation of action functions. This is very similar to the extra argument option in redux-thunk#injecting-a-custom-argument.
This branch is based on my new actions branch/PR. The other branch should be merged before this as implementing this functionality on the current actions logic would get kind of confusing.
Why?
Isomorphic actions / SSR
There are several use cases, an obvious one is passing different fetch implementations or similar
depending on if it is server or client side rendered.
Easier testing
If the action uses browser globals, they have to be mocked:
To test the following either a mock server has to be running, or something like proxyquire be used:
Both problems above are solved by passing in a
fetch
argument. Then we simply pass in a mockfetch
when testing:Build Size