Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #30 - update contributing guidelines and rename file #34

Merged
merged 5 commits into from
Oct 11, 2016

Conversation

ruqoyyasadiq
Copy link
Contributor

As per the issue #30 this PR contains work on renaming the contributing guidelines file to contributing.md. It also features updates to the file to reflect the easy accessibility to the issues and projects pages.


First Sign up [here](https://devcenter-square-slack.herokuapp.com/) to join the DC Square Slack Channel, then fill this [contributors form](https://docs.google.com/forms/d/1JiRNzYS69ojHPCql254HMMmp72cRb2TMGVC6BiOTw6E/viewform?c=0&w=1) to get added to the the Disease Info Contributors' channel.

**The #1 contribution you could make is to blog, share, post, tweet, and tell people about disease-info. This will go a long way in building a sustainable community.**

We are happy to accept contributions of any kind, including feedback and ideas, translations for other locales, and functionality.
Your next stop would be at the [issues page](https://github.com/devcenter-square/disease-info/issues). Here can find a list of issues to fixed as regards to the ongoing project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work @andela-rsadiq 👍

See this typo on line 12 -> ...Here you can find a list of issues to fix as regards either the ongoing project, or bugs on the app.


First Sign up [here](https://devcenter-square-slack.herokuapp.com/) to join the DC Square Slack Channel, then fill this [contributors form](https://docs.google.com/forms/d/1JiRNzYS69ojHPCql254HMMmp72cRb2TMGVC6BiOTw6E/viewform?c=0&w=1) to get added to the the Disease Info Contributors' channel.

**The #1 contribution you could make is to blog, share, post, tweet, and tell people about disease-info. This will go a long way in building a sustainable community.**

We are happy to accept contributions of any kind, including feedback and ideas, translations for other locales, and functionality.
Your next stop would be at the [issues page](https://github.com/devcenter-square/disease-info/issues). Here you can find a list of issues to fix as regards either the ongoing project, or bugs on the app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osioke corrected it here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is would the right word to use? I'm not sure, but I think should is preferable. Reason: that line sounds like a suggestion, using would betrays that. Correct me if I am wrong.
Beside this, I think this is good to go.

@osioke
Copy link
Contributor

osioke commented Oct 10, 2016

@SundayAdefila @ammezie @kinsomicrote @andela-ysanni I think the doc is good to go, or what do you think?

@x6iae
Copy link
Member

x6iae commented Oct 10, 2016

@andela-rsadiq 👍 Real good work. One more thing needed to close the issue with this PR, I suppose: -

mention the issues page and the repo's current project page

Is this the front-end UI? ( https://disease-info.herokuapp.com ) I need to confirm this first though.

@x6iae
Copy link
Member

x6iae commented Oct 10, 2016

Oh... yeah, above comment doesn't apply. the projects page is well captured as https://github.com/devcenter-square/disease-info/projects . From my end, the PR is good to go!

@x6iae
Copy link
Member

x6iae commented Oct 11, 2016

Great! merging now.

@x6iae x6iae merged commit 43af11d into devcenter-square:develop Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants