add endpoint to set/unset the is_active property of a disease, comple…

…tes #39, fully fixes #27
devcenter-square · Oct 15, 2017 · 0d5dabb · 0d5dabb
1 parent bf8e596
commit 0d5dabb
Show file tree

Hide file tree

Showing 6 changed files with 47 additions and 0 deletions.
diff --git a/app/controllers/diseases_controller.rb b/app/controllers/diseases_controller.rb
@@ -1,4 1,5 @@
 class DiseasesController < ApplicationController
  before_action :set_disease, only: [:show, :set_active_status]
 
  def index
  if permitted_params.include?(:data_source)
@@ -9,6 10,17 @@ def index
  end
 
  def show
  end
 
  def set_active_status
  # falsey values like boolean 'false', 'nil' evaluates to false
  is_active = !!params[:is_active] == true
 
  @disease.update_attribute(:is_active, is_active)
  end
 
  private
  def set_disease
  @disease = Disease.where("lower(name) LIKE?", "%#{permitted_params[:disease].downcase}%").first
  end
 

diff --git a/app/views/diseases/index.jbuilder b/app/views/diseases/index.jbuilder
@@ -9,4 9,5 @@ json.diseases @diseases do |disease|
  json.treatment disease.treatment
  json.prevention disease.prevention
  json.more disease.more
  json.is_active disease.is_active
 end
diff --git a/app/views/diseases/set_active_status.jbuilder b/app/views/diseases/set_active_status.jbuilder
@@ -0,0 1,13 @@
 json.disease do
  json.id @disease.id
  json.name @disease.name
  json.data_updated_at @disease.date_updated
  json.facts @disease.facts
  json.symptoms @disease.symptoms
  json.transmission @disease.transmission
  json.diagnosis @disease.diagnosis
  json.treatment @disease.treatment
  json.prevention @disease.prevention
  json.more @disease.more
  json.is_active @disease.is_active
 end
diff --git a/app/views/diseases/show.jbuilder b/app/views/diseases/show.jbuilder
@@ -9,4 9,5 @@ json.disease do
  json.treatment @disease.treatment
  json.prevention @disease.prevention
  json.more @disease.more
  json.is_active @disease.is_active
 end
diff --git a/config/routes.rb b/config/routes.rb
@@ -1,6 1,7 @@
 Rails.application.routes.draw do
  root :to => 'diseases#index'
  resources :diseases, param: :disease
  put '/diseases/:disease/set_active_status', to: 'diseases#set_active_status'
 
  # This handles 404 Error, 500 Error, and 422 Error
  get "/404" => "application#not_found"

diff --git a/spec/controllers/diseases_controller_spec.rb b/spec/controllers/diseases_controller_spec.rb
@@ -49,4 49,23 @@
  end
  end
 
  describe "PUT#set_active_status" do
  it "should update disease to non-active when param is set to false or zero or empty" do
  [false, nil].each do |value|
  # disease is_active is true by default
  disease = create(:disease)
  put :set_active_status, disease: disease.name, is_active: value
  expect(disease.reload.is_active).to eq false
  end
  end
 
  it "should update disease to active when given a truthy value" do
  [true, 'true'].each do |value|
  disease = create(:disease, is_active: false)
  put :set_active_status, disease: disease.name, is_active: value
  expect(disease.reload.is_active).to eq true
  end
  end
  end
 
 end