Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same way we have
Rule.Name
andRuleSet.Id
we should also haveRule.Id
to have an api more type safe.This PR also do another minor improvements in the code around these values.
Thanks to @TWiStErRob because the main idea of this PR came from him and we work on it on a fast pair programming session.
@TWiStErRob tell me if there is something else that I should cover.
Blocked by: