Indroduce Rule.Id
#7468
Open
Indroduce Rule.Id
#7468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
force-pushed
the
indroduce-rule.id
branch
from
dffb363
to
34c7a11
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7468 /- ##
============================================
Coverage 84.68% 84.71% 0.02%
Complexity 4195 4195
============================================
Files 575 574 -1
Lines 12011 12011
Branches 2480 2480
============================================
Hits 10172 10175 3
Misses 587 586 -1
Partials 1252 1250 -2 ☔ View full report in Codecov by Sentry. |
BraisGabin
force-pushed
the
indroduce-rule.id
branch
from
34c7a11
to
198a2aa
Compare
BraisGabin
force-pushed
the
indroduce-rule.id
branch
from
198a2aa
to
95aec44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same way we have
Rule.NameandRuleSet.Idwe should also haveRule.Idto have an api more type safe.This PR also do another minor improvements in the code around these values.
Thanks to @TWiStErRob because the main idea of this PR came from him and we work on it on a fast pair programming session.
@TWiStErRob tell me if there is something else that I should cover.
Blocked by: