Clean up the test failure output #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, don't throw an exception when the tests fail, instead return with exit status 1.
hayd
force-pushed
the
clean-up-test-fail
branch
from
629a646
to
5097357
Compare
ry
reviewed
Feb 20, 2019
testing/mod.ts
Outdated
| @@ -6,11 6,18 @@ interface Constructor { | |||
| new (...args: any[]): any; | |||
| } | |||
|
|
|||
| export class AssertionError extends Error { | |||
There was a problem hiding this comment.
Is this needed to avoid the stack trace?
There was a problem hiding this comment.
No, good point this is distinct. Initially when I was debugging something it wasn't immediately clear whether or not it was another Error or from the assert, this change disambiguates.
There was a problem hiding this comment.
Can we also show which assert failed?
There was a problem hiding this comment.
in a separate PR. this one is just a one line change.
This reverts commit 5097357.
ry
approved these changes
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, don't throw an exception when the tests fail,
instead return with exit status 1.
Before:
After: