File server tests #125
Merged
File server tests #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayd
commented
Jan 17, 2019
| @@ -16,21 14,12 @@ import "fs/path/relative_test.ts"; | |||
| import "fs/path/resolve_test.ts"; | |||
| import "fs/path/zero_length_strings_test.ts"; | |||
| import "io/bufio_test.ts"; | |||
| import "io/ioutil_test.ts"; | |||
There was a problem hiding this comment.
Aside: I wasn't sure if ioutil should remain here, it's a badly named file atm.
If ioutil is useful outside of ws we should be a little more descriptive... else move it to ws.
There was a problem hiding this comment.
I agree the name isn't great - but it comes from go - so at least there's that president : https://golang.org/pkg/io/ioutil/
I think it's useful outside of WS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a couple of miscellaneous cleanups (test files not being run).
xlink: #108