Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorgnanize repos, examples and tests #105

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Reorgnanize repos, examples and tests #105

merged 1 commit into from
Jan 12, 2019

Conversation

hayd
Copy link
Contributor

@hayd hayd commented Jan 12, 2019

closes #76

Note: I also added the ws tests and moved them to a new directory. These were not being run before.

Edit: It's also worth noting that this is going to be a breaking change if people aren't using commit/tags in their urls!

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks! LGTM

@ry ry merged commit c5e6e01 into denoland:master Jan 12, 2019
@hayd hayd deleted the reorg branch January 12, 2019 22:01
@hayd
Copy link
Contributor Author

hayd commented Jan 13, 2019

@ry this needs to go along with this: https://github.com/denoland/registry/pull/29
Apologies, I didn't think about this bit!

@ry
Copy link
Member

ry commented Jan 13, 2019

This is an argument for having the registry merged into this repo

@hayd
Copy link
Contributor Author

hayd commented Jan 13, 2019

Perhaps. But that renaming isnt backwards compatible and will break code, is true outside of deno_std as well.

@ry
Copy link
Member

ry commented Jan 13, 2019

People should not link to master branch if they want a stable link.
Example: https://deno.land/x/[email protected]/file_server.ts

That said, in the future we will need to be more careful about renaming files.

ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorg
3 participants