feat: resolve_import #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jun 23, 2024
rs-lib/src/lib.rs
Outdated
| @@ -1118,6 1119,8 @@ fn resolve_imports_match( | |||
| return Ok(Some(url)); | |||
| } | |||
|
|
|||
| log::debug!("Backtrace: {}", std::backtrace::Backtrace::force_capture()); | |||
There was a problem hiding this comment.
Is this on purpose or left by accident?
There was a problem hiding this comment.
Accident. I don’t remember writing this lol
dsherret
commented
Jun 24, 2024
dsherret
commented
Jun 24, 2024
bartlomieju
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves resolve_import from deno_graph:
https://github.com/denoland/deno_graph/blob/15db6e5fb6d3faea027e16c3d9ce6498b11beed2/src/module_specifier.rs#L53
This sort of makes sense to move here for situations where someone does not have an import map and still wants to resolve specifiers. This will be useful for code resuse in deno_graph and deno_config where deno_config does not depend on deno_graph.