Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use Arc<[u8]> instead of Arc<Vec<u8>> #139

Merged
merged 1 commit into from
Jul 22, 2023
Merged

chore: use Arc<[u8]> instead of Arc<Vec<u8>> #139

merged 1 commit into from
Jul 22, 2023

Conversation

lucacasonato
Copy link
Member

This removes a double boxing, and allows zero-copy loading into
deno_core through FastString::Arc.

@lucacasonato
chore: use Arc<[u8]> instead of Arc<Vec<u8>>
8fed800 
This removes a double boxing, and allows zero-copy loading into
deno_core through `FastString::Arc`.
dsherret
dsherret approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 586f816 into main Jul 22, 2023
@lucacasonato lucacasonato deleted the opaque_modules branch July 22, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @dsherret