Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: only serialize as 2.1 wih npm_snapshot #137

Merged
merged 2 commits into from
Jul 17, 2023
Merged

feat: only serialize as 2.1 wih npm_snapshot #137

merged 2 commits into from
Jul 17, 2023

Conversation

lucacasonato
Copy link
Member

Previously all outputted eszips were always 2.1. With this change we continue to
serialize a 2.0 if no npm_snapshot is present.

@lucacasonato
feat: only serialize as 2.1 wih npm_snapshot
124225c 
Previously all outputted eszips were always 2.1. With this change we
continue to serialize a 2.0 if no npm_snapshot is present.
@lucacasonato
add tests
8efc506
dsherret
dsherret approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucacasonato lucacasonato merged commit e9a74ba into main Jul 17, 2023
@lucacasonato lucacasonato deleted the output_2.0_when_possible branch July 17, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @dsherret