Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve dynamic npm specifiers one at a time #498

Merged
merged 6 commits into from
Jun 10, 2024
Merged

fix: resolve dynamic npm specifiers one at a time #498

merged 6 commits into from
Jun 10, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jun 10, 2024 •
edited
Loading

Most of the tests for this are in the CLI. This simplifies some stuff in deno_graph and makes it possible for a single dynamic npm import to fail resolution.

@dsherret dsherret marked this pull request as ready for review June 10, 2024 22:36
@dsherret dsherret mentioned this pull request Jun 10, 2024
Merged
@dsherret dsherret merged commit 9c14de4 into denoland:main Jun 10, 2024
16 checks passed
@dsherret dsherret deleted the fix_resolve_dynamic_npm_specifiers_individually branch June 10, 2024 23:29
dsherret added a commit to denoland/deno that referenced this pull request Jun 11, 2024
@dsherret
fix(npm): resolve dynamic npm imports individually (#24170)
4bc96c5 
* denoland/deno_npm#57
* denoland/deno_graph#498

Closes #17802
nathanwhit pushed a commit to denoland/deno that referenced this pull request Jun 13, 2024
@dsherret @nathanwhit
fix(npm): resolve dynamic npm imports individually (#24170)
7cf15a4 
* denoland/deno_npm#57
* denoland/deno_graph#498

Closes #17802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsherret @bartlomieju