Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use an IndexSet for the graph roots #489

Merged
merged 4 commits into from
Jun 4, 2024
Merged

refactor: use an IndexSet for the graph roots #489

merged 4 commits into from
Jun 4, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 28, 2024 •
edited
Loading

Mainly 1, but rarely 2:

  1. This better represents the data because there can't be duplicates.
  2. It will make us more performant if someone has hundreds of thousands of dynamic imports (which is a secenario I never benchmarked tbh).

Used an IndexSet instead of BTreeSet because knowing the first specifier is sometimes useful.

@dsherret dsherret requested a review from bartlomieju June 4, 2024 13:37
@dsherret dsherret changed the title refactor: use a BTreeSet for the graph roots refactor: use a IndexSet for the graph roots Jun 4, 2024
@dsherret dsherret changed the title refactor: use a IndexSet for the graph roots refactor: use an IndexSet for the graph roots Jun 4, 2024
@dsherret dsherret merged commit 00763ac into denoland:main Jun 4, 2024
16 checks passed
@dsherret dsherret deleted the refactor_roots_btreeset branch June 4, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @marvinhagemeister