perf: move jsr manifest checksum to locker #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
May 27, 2024
| @@ -168,7 168,6 @@ pub struct TestBuilder { | |||
| workspace_members: Vec<WorkspaceMember>, | |||
| workspace_fast_check: bool, | |||
| lockfile_jsr_packages: BTreeMap<PackageReq, PackageNv>, | |||
| verify_and_fill_checksums: bool, | |||
There was a problem hiding this comment.
Accidentally leftover in last PR. This does nothing.
dsherret
commented
May 27, 2024
| .iter() | ||
| .map(|p| p.1.found_dependencies.len()) | ||
| .sum() | ||
| } |
There was a problem hiding this comment.
I'm using these two methods to tell whether the lockfile needs updating after building the graph in the CLI.
bartlomieju
reviewed
May 27, 2024
| pub fn verify_and_fill_checksums(&mut self, value: bool) -> &mut Self { | ||
| self.verify_and_fill_checksums = value; | ||
| pub fn ensure_locker(&mut self) -> &mut Self { | ||
| self.locker.get_or_insert_with(Default::default); | ||
| self | ||
| } | ||
|
|
||
| #[allow(unused)] |
There was a problem hiding this comment.
There are multiple test runners sharing this code and they unfortunately error when one of them doesn't use a method.
bartlomieju
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also it better organizes the code.