feat: use loader to verify https checksums #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
May 24, 2024
| )); | ||
| }) | ||
| .boxed_local(), | ||
| ); |
There was a problem hiding this comment.
This will be a perf improvement.
dsherret
commented
May 24, 2024
| @@ -159,33 158,87 @@ impl Range { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
| pub enum ModuleError { | |||
There was a problem hiding this comment.
I split this up into way more targeted error classes so that I could more easily tell when an integrity check fails. This will make things easier in the CLI.
… a checksum error
dsherret
commented
May 27, 2024
| - name: Get tag version | ||
| if: contains(matrix.os, 'ubuntu') && startsWith(github.ref, 'refs/tags/') | ||
| id: get_tag_version | ||
| run: echo TAG_VERSION=${GITHUB_REF/refs\/tags\//} >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
This is unrealted to this PR. I just noticed it was not used.
bartlomieju
approved these changes
May 27, 2024
Comment on lines
87
to
94
| }, | ||
| { | ||
| let package_name = package_name.to_string(); | ||
| |e| JsrLoadError::PackageManifestLoad(package_name, Arc::new(e)) | ||
| }, | ||
| { | ||
| let package_name = package_name.to_string(); | ||
| || JsrLoadError::PackageNotFound(package_name) |
There was a problem hiding this comment.
This read very strange, I wonder if it would make more sense to assign them to variables before hand. But maybe not very important.
Comment on lines
188
to
189
| #[derive(Debug, Default, Clone)] | ||
| pub struct HashMapLocker(HashMap<ModuleSpecifier, LoaderChecksum>); |
There was a problem hiding this comment.
Where would we use this one? In deno vendor?
There was a problem hiding this comment.
Just in the tests probably (it's used in the tests in this repo)
| reporter: Option<&'a dyn Reporter>, | ||
| workspace_members: &'a [WorkspaceMember], | ||
| executor: &'a dyn Executor, | ||
| options: BuildOptions<'a>, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a perf improvement, but also it allows modifying https specifiers in the vendor folder without causing lockfile issues similar to jsr specifiers.