feat(symbols): collect symbols for params #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes type params, function params, and params declared through `infer X` in type annotations.
dsherret
approved these changes
May 25, 2024
| } | ||
| } | ||
|
|
||
| fn fill_expr(&self, symbol_id: SymbolId, expr: &Expr) { |
There was a problem hiding this comment.
Maybe add a comment here explaining why we need to fill expressions. I got confused by this initially.
| Pat::Array(n) => n.type_ann.as_ref(), | ||
| Pat::Object(n) => n.type_ann.as_ref(), | ||
| Pat::Rest(_) | Pat::Invalid(_) | Pat::Expr(_) | Pat::Assign(_) => { | ||
| unreachable!() |
There was a problem hiding this comment.
We should add a comment saying why this is unreachable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes type params, function params, and params declared through
infer Xin type annotations.