fix: dynamic arg module search should ignore specific folder names #344
Conversation
|
No, it's only runtime. The LSP doesn't do this search. See #275 |
| .rsplit('/') | ||
| .find(|c| !c.is_empty()) | ||
| .map(|c| { | ||
| !c.starts_with('.') && c != "node_modules" && c != "vendor" |
There was a problem hiding this comment.
This somewhat aligns with what the CLI does here:
I wonder if we should match it exactly and this instead should be .git | vendor | node_modules?
There was a problem hiding this comment.
Yeah, I think we should unify it and also ignore .git directory
There was a problem hiding this comment.
Right now this ignores the .git directory. To clarify, this code should be updated to instead only ignore the git directory and not all hidden folders?
There was a problem hiding this comment.
Oh, sorry. I didn't read the code fully. I think that still makes sense - what if you try to import from .dist/ or .<framework_name>/? I can see a scenario where people try to do that.
There was a problem hiding this comment.
With the current code, they would just have to be specific or import a sub folder in that case.
There was a problem hiding this comment.
Actually, they could just do:
import(`./dist/${expr}`)Thinking about it more, I think we should ignore all hidden folders here because there's this way to import and in many cases I think people wouldn't want it searching hidden folders.
dsherret
deleted the
fix_dynamic_arg_search_ignore_node_modules_and_hidden
branch
Upgrades deno_doc for denoland/deno_graph#344
I think the dynamic argument module search should ignore certain folder names as they are almost guaranteed to not be wanted. This excludes hidden folders and folders named
node_modulesorvendor.