Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(symbols): move SymbolDeps out of the symbol graph #325

Merged
merged 22 commits into from
Nov 9, 2023
Merged

feat(symbols): move SymbolDeps out of the symbol graph #325

merged 22 commits into from
Nov 9, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Nov 8, 2023 •
edited
Loading

These are now lazily computed as there's no reason for these to be in the symbol graph.

@dsherret
Start of adding DefinitionUnresolved, but probably need to change the…
34b8330 
… Module to a Symbol as well
@dsherret
Add symbol for file
77e13ca
@dsherret
rename to module info to prevent confusion with the file symbol
147bc49
@dsherret
Add Info
ffbe8df
@dsherret
Add unresolved_specifiers example
8d55595
@dsherret
Add SymbolDecl for Module
6195f7b
@dsherret
Another test and improvement
e98ae1d
@dsherret
Another improvement
cdba01d
@dsherret
Start of adding parent ids
3fbb58f
@dsherret
Finish adding parent ids
1100231
@dsherret
Merge branch 'main' into feat_parent_ids
af7a79b
@dsherret
Improvements to parent/children and better "go to definition"
cce3a94
@dsherret
lint
bcd7bfd
@dsherret
feat(symbols): ability to look up a sub name of a SymbolDep
7912267
@dsherret
Add some more helpers
7b49513
@dsherret
Before refactor to make TsImportEquals a node
62999fd
@dsherret
Remove deps from always being computed
c37958b
@dsherret
Add symbol delcs in output
8b6829c
@dsherret
Clippy
8f79197
@dsherret
Merge branch 'main' into feat_symbol_dep_ref
f79b907
@dsherret dsherret changed the title feat(symbols): ability to look up a sub name of a SymbolDep feat(symbols): move SymbolDeps out of the symbol graph Nov 8, 2023
@dsherret dsherret marked this pull request as ready for review November 8, 2023 18:06
bartlomieju
bartlomieju approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice diif

@dsherret dsherret mentioned this pull request Nov 8, 2023
Closed
@dsherret dsherret merged commit 2726c49 into denoland:main Nov 9, 2023
4 checks passed
@dsherret dsherret deleted the feat_symbol_dep_ref branch November 9, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju