-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to discern between types directive and x-TypeScript-types #133
Labels
enhancement
New feature or request
Comments
I don't think they should specifically be seperate, as they represent the same functional concept, but should contain an optional range instead of a 0 range. |
dsherret
changed the title
Store types directive and x-TypeScript-types separately in the graph
Ability to discern between types directive and x-TypeScript-types
Feb 10, 2022
Sure. I updated the title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For
deno vendor
, it might be nice to have a way to represent/// <reference types="..." />
andx-TypeScript-types
separately in the graph while still providing a common method for themaybe_types_dependency
.This would also help us remove
Range
from being necessary forx-typescript-types
as the types directive could have a range, but thex-typescript-types
doesn't need one:deno_graph/src/graph.rs
Lines 1331 to 1340 in f8adbe4
Alternatively, I can just do a check for the start and end position all being zero, but that seems a little hacky.
The text was updated successfully, but these errors were encountered: