Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in prepare_stack_trace_callback when global interceptor throws #914

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Sep 22, 2024

Fix panic when a global interceptor is misconfigured or throws an exception.

Fixes denoland/deno#24985 (comment) and denoland/deno#26240

@bartlomieju
Copy link
Member

Maybe a short unit test?

…hrows

Fix panic when a global interceptor is misconfigured or throws an
exception. Example
denoland/deno#24985 (comment)
@littledivy littledivy force-pushed the prepare_stack_trace_callback_panic branch from bde3e43 to 9028a84 Compare October 14, 2024 14:30
@littledivy littledivy enabled auto-merge (squash) October 14, 2024 14:36
@littledivy littledivy merged commit 9dd5f80 into main Oct 14, 2024
18 checks passed
@littledivy littledivy deleted the prepare_stack_trace_callback_panic branch October 14, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants