Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add structured cloning to Deno.core #9458

Merged
merged 10 commits into from
Feb 16, 2021
Merged

feat: add structured cloning to Deno.core #9458

merged 10 commits into from
Feb 16, 2021

Conversation

inteon
Copy link
Contributor

@inteon inteon commented Feb 9, 2021

First step towards #3557, as discussed in #9323. Also includes some simple tests.

core/serialize_deserialize.rs Outdated Show resolved Hide resolved
core/serialize_deserialize.rs Outdated Show resolved Hide resolved
@inteon inteon marked this pull request as ready for review February 10, 2021 21:40
@inteon
Copy link
Contributor Author

inteon commented Feb 10, 2021

Blocked on #9466

@bartlomieju bartlomieju changed the title feat(deno/core): add structured cloning to deno core feat: add structured cloning to Deno.core Feb 16, 2021
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @inteon, great work!

Before landing I'll wait for Ben's review

Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

struct SerializeDeserialize {}

impl v8::ValueSerializerImpl for SerializeDeserialize {
#[allow(unused_variables)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What unused variables?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is required by v8::ValueSerializerImpl but is never used in core/bindings.rs (yet I think)

@bartlomieju bartlomieju merged commit e2a9119 into denoland:master Feb 16, 2021
@ry
Copy link
Member

ry commented Feb 16, 2021

Nice work @inteon - thanks!

@inteon inteon deleted the add_serialize_deserialize branch February 16, 2021 16:03
@kitsonk kitsonk mentioned this pull request Feb 17, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants