Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(std/wasi): add wasi-testsuite as a submodule #7042

Merged
merged 7 commits into from
Aug 25, 2020

Conversation

caspervonb
Copy link
Contributor

This replaces our current test suite with prebuilt test artifacts from the upstream test suite.

The test suite is a crate (quite possibly being split into per domain crates soon) of bins as a side effect of witx tooling and such being written in Rust but I'm bringing them in as prebuilt artifacts because I believe they should be considered to be immutable resources that exist outside of our required toolchain and dependency graph.

There's a little more context in WebAssembly/WASI#9. We've touched on moving it to github.com/WebAssembly eventually but for now "upstream" is me.

This replaces our test suite with prebuilt test artifacts from the
upstream wasi test suite.
@caspervonb caspervonb marked this pull request as ready for review August 13, 2020 16:55
@caspervonb
Copy link
Contributor Author

WDYT @ry?

@caspervonb caspervonb marked this pull request as draft August 21, 2020 17:35
@caspervonb
Copy link
Contributor Author

Added this as a submodule in web-wasi (rewrite, lessons learned, et cetera) over at khronosproject/web-wasi#3.

Preferably we can bring it in as a submodule here too so it's a simple tag bump to bring in new versions.

@caspervonb caspervonb changed the title test(std/wasi): use upstream wasi test suite test(std/wasi): add wasi-testsuite as a submodule Aug 22, 2020
@caspervonb caspervonb marked this pull request as ready for review August 22, 2020 11:43
@bartlomieju bartlomieju requested a review from ry August 24, 2020 16:23
@ry
Copy link
Member

ry commented Aug 24, 2020

Not green

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Casper

@ry ry merged commit f717426 into denoland:master Aug 25, 2020
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@caspervonb caspervonb deleted the test-std-wasi-use-upstream-test-suite branch May 24, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants