Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude prebuilt from deno_src release #3272

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Exclude prebuilt from deno_src release #3272

merged 2 commits into from
Nov 5, 2019

Conversation

hayd
Copy link
Contributor

@hayd hayd commented Nov 5, 2019

chrmoritz
chrmoritz approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@chrmoritz chrmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small addition, otherwise LGTM 👍

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@hayd @chrmoritz
Exclude node_modules in deno_src
0e58729 
Keeping a empty node_modules was required, because the test relied on the node_modules symlink to point to a valid target. This is no longer the case since denoland#3247, so we can remove this workaround too.

Co-Authored-By: Christian Moritz <[email protected]>
@chrmoritz
Copy link
Contributor

chrmoritz commented Nov 5, 2019 •
edited
Loading

Another side note: It is common practice to put the version number the the release asserts name too (e.g. deno_v0.23.0_linux_x64.gz or deno_v0.23.0_src.tar.gz). Not having one in it currently breaks homebrew automatic version detection (and the formula requires an explicit version number because of that). But implementing this would require some significant changes to deno_install too.

ry
ry approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 92b8674 into denoland:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@chrmoritz chrmoritz chrmoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hayd @chrmoritz @ry