Add support for top-level-for-await #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Oct 27, 2019
|
Ok, I added in a few places I saw it. Assuming this should be preferred over window.onload... I also discovered the ws README example code was broken, so I ported it over from the examples. Although it may be better just to delete it (and point to those examples). _048_media_types_jsx failed in the first commit, presumably it's this: Lines 71 to 72 in 51dd91a (This particularly test requires the http_server to be up at compile time.) |
ry
reviewed
Oct 27, 2019
| const body = new TextEncoder().encode("Hello World\n"); | ||
| for await (const req of serve(":8000")) { | ||
| req.respond({ body }); | ||
| } |
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like top-level for-await already works with js. This PR allows it in typescript files too.
Unfortunately prettier/babel doesn't accept it (eslint does). So the js test file is ignored... Confusingly the ts file doesn't suffer with the same issue.
I'm not sure a good resolution going forward but am putting the PR up anyways.
cc #471