Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust stable to 1.38.0 #3030

Merged
merged 3 commits into from
Oct 3, 2019
Merged

Update rust stable to 1.38.0 #3030

merged 3 commits into from
Oct 3, 2019

Conversation

hayd
Copy link
Contributor

@hayd hayd commented Sep 26, 2019 •
edited
Loading

Note: This addresses all but one of the new clippy errors, I think this one remains:

EDIT: I addressed the last clippy issue using match if.

@hayd
Copy link
Contributor Author

hayd commented Sep 27, 2019 •
edited
Loading

The build error looks to be an update required for sccache (that fixed mozilla/sccache#488).

@ry
Copy link
Member

ry commented Oct 2, 2019 •
edited
Loading

Upgrading sccache in #3051 - will try this once it's landed.

ry
ry approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @hayd

@ry ry merged commit f7bbd71 into denoland:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hayd @ry