feat(ext/canvas): enhance createImageBitmap specification compliance
#25517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xcept for JPG and animated image - https://mimesniff.spec.whatwg.org/#matching-an-image-type-pattern
- adding `DOMExceptionInvalidStateError` in global due to handling not supported image format - animation image is not supported currently
Hajime-san
force-pushed
the
update-imagebitmap
branch
from
a234586
to
1de527f
Compare
Hajime-san
force-pushed
the
update-imagebitmap
branch
from
055395a
to
bd77fb9
Compare
petamoriken
reviewed
Sep 29, 2024
Comment on lines
652
to
653
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
It would be better to add a test for EXIF orientation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
basic support for decoding image format
jpeg,png,gif,bmp,ico,webpissues for supporting AVIF
The AVIF image format is supported by all browsers today.
However, the standardization of sniffing mime type seems to have hard going.
supportcolorSpaceforImageDataThere can convert color space fromsrgbtodisplay-p3withcreateImageBitmap.This was a misunderstanding on my part, so I reverted it.
The conversion using the
ImageDatacolorSpace option was probably the responsibility ofCanvasRenderingContext2D.I've left the implementation commented out as it may be useful as a reference for implementing
CanvasRenderingContext2DorOffscreenCanvasRenderingContext2D.support
colorSpaceConversionoptionThe specifications are not particularly clear about the implementation details, and I had a hard time understanding its behavior, but I eventually do reverse engineering the results of wpt and implemented it to be consistent with those results.
port to Rust
To simplify code, almost logic moved to Rust side.
added a simple architecture document for README
It is basically based on the
imageimplementation, and I wrote roughly how you can handle data effectively.performance impact
I was curious to see if the increased amount of Rust code, especially static dispatch, was affecting the bootstrap time of the runtime.
I'm not very confident about the suitability of this benchmark.
bootstrap
API benchmark
% target/release/deno bench bench.ts CPU | Apple M1 Runtime | Deno 2.0.0-rc.2 (aarch64-apple-darwin) file:///path/to/deno/bench.ts benchmark time/iter (avg) iter/s (min … max) p75 p99 p995 ------------------- ----------------------------- --------------------- -------------------------- createImageBitmap 2.6 µs 380,600 ( 2.5 µs … 2.9 µs) 2.6 µs 2.9 µs 2.9 µs% target/release/deno bench bench.ts CPU | Apple M1 Runtime | Deno 1.46.1 (aarch64-apple-darwin) file:///path/to/deno/bench.ts benchmark time/iter (avg) iter/s (min … max) p75 p99 p995 ------------------- ----------------------------- --------------------- -------------------------- createImageBitmap 3.5 µs 287,200 ( 3.3 µs … 3.6 µs) 3.5 µs 3.6 µs 3.6 µsextra
The benchmarks below are for when the argument to
op_create_image_bitmapis a struct except for the first argument ofbuf.It seems that serializing the argument to
opas a struct has a fairly large impact on performance.This may apply to things other than
op_create_image_bitmapas well.% target/release/deno bench bench.ts CPU | Apple M1 Runtime | Deno 2.0.0-rc.2 (aarch64-apple-darwin) file:///path/to/deno/bench.ts benchmark time/iter (avg) iter/s (min … max) p75 p99 p995 ------------------- ----------------------------- --------------------- -------------------------- createImageBitmap 4.2 µs 235,900 ( 4.1 µs … 4.5 µs) 4.3 µs 4.5 µs 4.5 µsplans for enhancement in another PRs
improve performance
There is known to that processing image is a cpu-bound task. So,
op_create_image_bitmapwill be async fn and consider to be data-parallelism with usingrayon.align error message