Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid ipv6 hostname on deno serve #25482

Merged
merged 6 commits into from
Sep 6, 2024
Merged

fix: invalid ipv6 hostname on deno serve #25482

merged 6 commits into from
Sep 6, 2024

Conversation

marvinhagemeister
Copy link
Contributor

@marvinhagemeister marvinhagemeister commented Sep 6, 2024 •
edited
Loading

This PR fixes an invalid URL being printed when running deno serve

Before: invalid URL

$ deno serve --host localhost
deno serve: Listening on http://::1:8000/

After: valid URL

$ deno serve --host localhost
deno serve: Listening on http://[::1]:8000/

@marvinhagemeister marvinhagemeister enabled auto-merge (squash) September 6, 2024 09:22
@marvinhagemeister marvinhagemeister merged commit 73ab32c into main Sep 6, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the serve-hostname branch September 6, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinhagemeister @lucacasonato