feat(unstable/fmt): move yaml formatting behind unstable flag #24848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Aug 2, 2024
| "tests": { | ||
| "nothing": { | ||
| "args": "fmt", | ||
| "output": "Checked 1 file\n" |
There was a problem hiding this comment.
It's still loading the yaml file. I didn't think it was worth the effort to make that conditional as we'll be enabling this by default soon.
bartlomieju
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves YAML formatting behind an unstable flag for Deno 1.46. This will make it opt-in to start and then we can remove the flag to make it on by default in version of Deno after that.
This can be specified by doing
deno fmt --unstable-yamlor by specifying the following in a deno.json file:{ "unstable": ["fmt-yaml"] }cc @g-plane - It would be good to do the same for other languages.
Part of #12217